On Wed, Dec 21, 2022 at 2:40 PM Ben Gardon <bgardon@xxxxxxxxxx> wrote: > > On Wed, Dec 21, 2022 at 2:24 PM Ben Gardon <bgardon@xxxxxxxxxx> wrote: > > > > Cut and paste the implementation of the Shadow MMU to shadow_mmu.(c|h). > > This is a monsterously large commit, moving ~3500 lines. With such a > > large move, there's no way to make it easy. Do the move in one massive > > step to simplify dealing with merge conflicts and to make the git > > history a little easier to dig through. Several cleanup commits follow > > this one rather than preceed it so that their git history will remain > > easy to see. > > > > No functional change intended. > > > > Signed-off-by: Ben Gardon <bgardon@xxxxxxxxxx> > > Woops, I guess this message bounced because the patch was just too long. > I can try to split it in two if folks would prefer, or just send a > list of the functions / definitions moved. > Interesting, I can see this patch in my email client, lore.kernel.org/lkml but not in patchwork.kernel.org One more way can be to move declarations to shadow_mmu.h first and then in subsequent patch move definitions to shadow_mmu.c. I do agree it won't reduce size much but it will make it easier to see which functions are becoming the part of API. > > --- > > arch/x86/kvm/debugfs.c | 1 + > > arch/x86/kvm/mmu/mmu.c | 4526 ++++--------------------------- > > arch/x86/kvm/mmu/mmu_internal.h | 4 +- > > arch/x86/kvm/mmu/shadow_mmu.c | 3408 +++++++++++++++++++++++ > > arch/x86/kvm/mmu/shadow_mmu.h | 145 + > > 5 files changed, 4086 insertions(+), 3998 deletions(-) > > > > ... > > > -- > > 2.39.0.314.g84b9a713c41-goog > >
