On 11/01/2023 18:06, David Woodhouse wrote:
From: David Woodhouse <dwmw@xxxxxxxxxxxx> Documentation/virt/kvm/locking.rst tells us that kvm->lock is taken outside vcpu->mutex. But that doesn't actually happen very often; it's only in some esoteric cases like migration with AMD SEV. This means that lockdep usually doesn't notice, and doesn't do its job of keeping us honest. Ensure that lockdep *always* knows about the ordering of these two locks, by briefly taking vcpu->mutex in kvm_vm_ioctl_create_vcpu() while kvm->lock is held. Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx> --- virt/kvm/kvm_main.c | 7 +++++++ 1 file changed, 7 insertions(+)
Reviewed-by: Paul Durrant <paul@xxxxxxx>