On Mon, Jan 09, 2023 at 07:47:03AM +0000, Tian, Kevin wrote: > > From: Liu, Yi L <yi.l.liu@xxxxxxxxx> > > Sent: Monday, December 19, 2022 4:47 PM > > > > @@ -415,7 +416,7 @@ static int vfio_device_first_open(struct > > vfio_device_file *df, > > if (!try_module_get(device->dev->driver->owner)) > > return -ENODEV; > > > > - if (iommufd) > > + if (iommufd && !IS_ERR(iommufd)) > > ret = vfio_iommufd_bind(device, iommufd, dev_id, pt_id); > > else > > ret = vfio_device_group_use_iommu(device); > > can you elaborate how noiommu actually works in the cdev path? I still need someone to test the noiommu iommufd patch with dpdk, I'll post it in a minute For cdev conversion no-iommu should be triggered by passing in -1 for the iommufd file descriptor to indicate there is no translation. Then the module parameter and security checks should be done before allowing the open to succeed with an identity translation in place. There should be a check that there is no iommu driver controlling the device as well.. Jason
