On Mon, Jan 09, 2023 at 05:46:04AM +0000, Tian, Kevin wrote: > > From: Liu, Yi L <yi.l.liu@xxxxxxxxx> > > Sent: Monday, December 19, 2022 4:47 PM > > > > This prepares to add ioctls for device cdev fd. This infrastructure includes: > > - vfio_iommufd_bind() to accept pt_id, and also return back dev_id to > > caller. > > - vfio_iommufd_attach() to support iommufd pgtable attach after > > bind_iommufd. > > Please mention that pt_id==-1 implies detach. Oh, do we want that or a dedicated ioctl? -1 isn't a u32.. Jason