Andrew Jones <andrew.jones@xxxxxxxxx> writes:
We could cap at 8 for ACCEL=tcg. Even if no one cares, I'm tempted to do it so no one hits the same little landmine as me in the future.
TCG supports up to 255 CPUs. The only reason it'd have a max of 8 is if you were configuring a GICv2 instead of a GICv3.
That makes sense as it was the GICv2 tests failing that led me to this rabbit hole. In that case, it should be completely safe to delete the loop because all the GICv2 tests have ternary condition to cap at 8 already. If we can't delete, the loop logic is still a suboptimal way to do things as qemu reports the max cpus it can take. We could read MAX_SMP from qemu error output.
