Em Wed, Dec 21, 2022 at 08:57:11AM +0000, Marc Zyngier escreveu: > On Wed, 21 Dec 2022 07:06:41 +0000, Gavin Shan <gshan@xxxxxxxxxx> wrote: > > On 12/21/22 5:08 AM, Arnaldo Carvalho de Melo wrote: > > > I tried to build make -C tools/testing/selftests/kvm/ to check that an > > > update I made to the tools/include/uapi/linux/kvm.h file wouldn't break > > > the KVM selftests, but I stumbled on an unrelated build failure where > > > it tries to use a define that isn't available in the system headers > > > (fedora 36), so add it conditionally. > > > Shouldn't this use the tools/ headers? Anyway, see if this is something > > > useful. > > > Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> > > > --- > > > diff --git a/tools/testing/selftests/kvm/include/kvm_util.h b/tools/testing/selftests/kvm/include/kvm_util.h > > > index c9286811a4cb88e0..4ab76fd22efd951d 100644 > > > --- a/tools/testing/selftests/kvm/include/kvm_util.h > > > +++ b/tools/testing/selftests/kvm/include/kvm_util.h > > > @@ -10,4 +10,8 @@ > > > #include "kvm_util_base.h" > > > #include "ucall_common.h" > > > +#ifndef KVM_CAP_DIRTY_LOG_RING_ACQ_REL > > > +#define KVM_CAP_DIRTY_LOG_RING_ACQ_REL 223 > > > +#endif > > > + > > > #endif /* SELFTEST_KVM_UTIL_H */ > > I don't think it's necessary because KVM_CAP_DIRTY_LOG_RING_ACQ_REL has been > > defined in include/uapi/linux/kvm.h, which needs to be synchronized to > > /usr/include/linux/kvm.h, included by tools/testing/selftests/kvm/include/kvm_util_base.h Until that happens, I can't test build it, and: ⬢[acme@toolbox perf]$ rpm -qf /usr/include/linux/kvm.h kernel-headers-6.0.5-200.fc36.x86_64 is in a distro package. - Arnaldo > > By the way, you forgot to copy the correct maillist, kvm@xxxxxxxxxxxxxxx or > > kvmarm@xxxxxxxxxxxxxxxxxxxxx. > > Actually, the latter is now deprecated, and will be turned off early > next year. kvmarm@xxxxxxxxxxxxxxx is the new kid on the block (I just > need to get Konstantin to turn on the archiving process). > > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible. -- - Arnaldo
