Re: [PATCH 0/3] accel: Silent few -Wmissing-field-initializers warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/12/22 15:42, Daniel P. Berrangé wrote:
On Tue, Dec 20, 2022 at 03:35:29PM +0100, Philippe Mathieu-Daudé wrote:
Silent few -Wmissing-field-initializers warnings enabled by -Wextra.

Philippe Mathieu-Daudé (3):
   tcg: Silent -Wmissing-field-initializers warning
   accel/kvm: Silent -Wmissing-field-initializers warning
   softmmu: Silent -Wmissing-field-initializers warning

  accel/kvm/kvm-all.c | 4 ++--
  softmmu/vl.c        | 2 +-
  tcg/tcg-common.c    | 2 +-
  3 files changed, 4 insertions(+), 4 deletions(-)

If we're going to the trouble of fixing violations (which is
good), then we shouuld also add  -Wmissing-field-initializers
(or -Wextra) to warn_flags in configure, to prevent regressions
again in future.

Yes, I plan to add it at the end. I choose to split in small
contained series to avoid spamming every maintainers, but this
is actually that trivial that I could have sent as a big one...

Thanks for the review!



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux