Re: [PATCH-for-8.0 3/4] hw/ppc/spapr: Reduce "vof.h" inclusion

Daniel Henrique Barboza <danielhb413@xxxxxxxxx> · Fri, 16 Dec 2022 13:34:09 -0300

On 12/13/22 09:35, Philippe Mathieu-Daudé wrote:
Currently objects including "hw/ppc/spapr.h" are forced to be
target specific due to the inclusion of "vof.h" in "spapr.h".

"spapr.h" only uses a Vof pointer, so doesn't require the structure
declaration. The only place where Vof structure is accessed is in
spapr.c, so include "vof.h" there, and forward declare the structure
in "spapr.h".

Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
---

Reviewed-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx>

  hw/ppc/spapr.c         | 1 +
  include/hw/ppc/spapr.h | 3 ++-
  2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 66b414d2e9..f38a851ee3 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -62,6 +62,7 @@
  #include "hw/ppc/fdt.h"
  #include "hw/ppc/spapr.h"
  #include "hw/ppc/spapr_vio.h"
+#include "hw/ppc/vof.h"
  #include "hw/qdev-properties.h"
  #include "hw/pci-host/spapr.h"
  #include "hw/pci/msi.h"
diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
index 04a95669ab..5c8aabd444 100644
--- a/include/hw/ppc/spapr.h
+++ b/include/hw/ppc/spapr.h
@@ -12,7 +12,6 @@
  #include "hw/ppc/spapr_xive.h"  /* For SpaprXive */
  #include "hw/ppc/xics.h"        /* For ICSState */
  #include "hw/ppc/spapr_tpm_proxy.h"
-#include "hw/ppc/vof.h"
  
  struct SpaprVioBus;
  struct SpaprPhbState;
@@ -22,6 +21,8 @@ typedef struct SpaprEventLogEntry SpaprEventLogEntry;
  typedef struct SpaprEventSource SpaprEventSource;
  typedef struct SpaprPendingHpt SpaprPendingHpt;
  
+typedef struct Vof Vof;
+
  #define HPTE64_V_HPTE_DIRTY     0x0000000000000040ULL
  #define SPAPR_ENTRY_POINT       0x100
  






