On Fri, Dec 16, 2022, Michal Luczaj wrote: > On 12/16/22 09:59, Yu Zhang wrote: > > +++ b/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c > > @@ -20,7 +20,7 @@ > > #include <sys/eventfd.h> > > > > /* Defined in include/linux/kvm_types.h */ > > -#define GPA_INVALID (~(ulong)0) > > +#define INVALID_GFN (~(ulong)0) > > > Thank you for fixing the selftest! > > Regarding xen_shinfo_test.c, a question to maintainers, would it be ok if I > submit a simple patch fixing the misnamed cache_init/cache_destroy => > cache_activate/cache_deactivate or it's just not worth the churn now? It's not too much churn. My only hesitation would be that chasing KVM names is usually a fruitless endeavor, but in this case I agree (de)activate is better terminology even if KVM changes again in the future.
