On Mon, Dec 12, 2022 at 5:24 AM Like Xu <like.xu.linux@xxxxxxxxx> wrote: > > On 10/12/2022 3:49 am, Aaron Lewis wrote: > > Aaron Lewis (2): > > KVM: x86/pmu: Prevent the PMU from counting disallowed events > > Nice and it blames to me, thanks. > > Would you share a detailed list of allowed and denied events (e.g. on ICX) > so we can do more real world testing ? > > Ref: #define KVM_PMU_EVENT_FILTER_MAX_EVENTS 300 TBH, 300 entries is plenty for Intel. It's AMD that has the issue, but that's addressed with 'masked events'. What type of testing would you like to see for filtering or the PMU in general as a selftest? Currently, the test uses architectural events, but with this series we are really only testing 2 of them. There is plenty of room for more / better testing with just architectural events alone. I also add more testing and more variety of counters with masked events. I'm curious where you would like to see additional testing and what real world testing you'd like to see added. > > > KVM: selftests: Test the PMU event "Instructions retired" > > And, do you have further plans to cover more pmu testcases via selftests ? I don't have immediate plans beyond the 2 mentioned above, but I'm always open to more / better testing.