On Wed, 14 Dec 2022 13:38:14 +0100
Nico Boehr <nrb@xxxxxxxxxxxxx> wrote:
> Right now, we have a test which sets storage keys, then migrates the VM
> and - after migration finished - verifies the skeys are still there.
>
> Add a new version of the test which changes storage keys while the
> migration is in progress. This is achieved by adding a command line
> argument to the existing migration-skey test.
just some small cosmetic issues
>
> Signed-off-by: Nico Boehr <nrb@xxxxxxxxxxxxx>
> ---
> s390x/migration-skey.c | 218 +++++++++++++++++++++++++++++++++++++----
> s390x/unittests.cfg | 15 ++-
> 2 files changed, 210 insertions(+), 23 deletions(-)
>
> diff --git a/s390x/migration-skey.c b/s390x/migration-skey.c
> index a91eb6b5a63e..0f862cc9d821 100644
> --- a/s390x/migration-skey.c
> +++ b/s390x/migration-skey.c
> @@ -2,6 +2,12 @@
> /*
> * Storage Key migration tests
> *
> + * There are two variants of this test:
> + * - sequential: sets some storage keys on pages, migrates the VM and then
"set storage keys on some pages"?
or just "set some storage keys"
> + * verifies the storage keys are still as we expect.
s/the/that the/
> + * - parallel: start migration of a VM and set and check storage keys on some
s/of a VM/of VM/ or s/of a VM/of the VM/ or even just s/of the VM//
> + * pages while migration is in process.
> + *
> * Copyright IBM Corp. 2022
> *
> * Authors:
> @@ -13,16 +19,45 @@
> #include <asm/facility.h>
> #include <asm/page.h>
> #include <asm/mem.h>
> -#include <asm/interrupt.h>
> +#include <asm/barrier.h>
> #include <hardware.h>
> +#include <smp.h>
> +
[...]
> +
> +static void print_usage(void)
> +{
> + report_info("Usage: migration-skey [parallel|sequential]");
--parallel and --sequential
> +}
> +
[...]
