> From: Jason Gunthorpe <jgg@xxxxxxxxxx> > Sent: Friday, December 9, 2022 4:27 AM > > @@ -170,7 +170,7 @@ static int iommufd_device_setup_msi(struct > iommufd_device *idev, > * interrupt outside this iommufd context. > */ > if (!device_iommu_capable(idev->dev, IOMMU_CAP_INTR_REMAP) > && > - !irq_domain_check_msi_remap()) { > + !msi_device_has_secure_msi(idev->dev)) { > if (!allow_unsafe_interrupts) > return -EPERM; > this is where iommufd and vfio diverge. vfio has a check to ensure all devices in the group has secure_msi. but iommufd only imposes the check per device.