Hi Steve, https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Steve-Sistare/vfio-virtual-address-update-redo/20221207-055735 base: https://github.com/awilliam/linux-vfio.git for-linus patch link: https://lore.kernel.org/r/1670363753-249738-9-git-send-email-steven.sistare%40oracle.com patch subject: [PATCH V1 8/8] vfio/type1: change dma owner config: i386-randconfig-m021 compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <error27@xxxxxxxxx> New smatch warnings: drivers/vfio/vfio_iommu_type1.c:1546 same_file_mapping() error: uninitialized symbol 'pgoff2'. drivers/vfio/vfio_iommu_type1.c:1547 same_file_mapping() error: uninitialized symbol 'len2'. drivers/vfio/vfio_iommu_type1.c:1547 same_file_mapping() error: uninitialized symbol 'flags2'. vim +/pgoff2 +1546 drivers/vfio/vfio_iommu_type1.c f42f5cc4de6087 Steve Sistare 2022-12-06 1517 static bool same_file_mapping(struct mm_struct *mm1, unsigned long vaddr1, f42f5cc4de6087 Steve Sistare 2022-12-06 1518 struct mm_struct *mm2, unsigned long vaddr2) f42f5cc4de6087 Steve Sistare 2022-12-06 1519 { f42f5cc4de6087 Steve Sistare 2022-12-06 1520 const unsigned long mask = VM_READ | VM_WRITE | VM_EXEC | VM_SHARED; f42f5cc4de6087 Steve Sistare 2022-12-06 1521 struct inode *inode1 = NULL, *inode2 = NULL; f42f5cc4de6087 Steve Sistare 2022-12-06 1522 unsigned long pgoff1, len1, flags1; f42f5cc4de6087 Steve Sistare 2022-12-06 1523 unsigned long pgoff2, len2, flags2; f42f5cc4de6087 Steve Sistare 2022-12-06 1524 struct vm_area_struct *vma; f42f5cc4de6087 Steve Sistare 2022-12-06 1525 f42f5cc4de6087 Steve Sistare 2022-12-06 1526 mmap_read_lock(mm1); f42f5cc4de6087 Steve Sistare 2022-12-06 1527 vma = find_vma(mm1, vaddr1); f42f5cc4de6087 Steve Sistare 2022-12-06 1528 if (vma && vma->vm_file) { f42f5cc4de6087 Steve Sistare 2022-12-06 1529 inode1 = vma->vm_file->f_inode; f42f5cc4de6087 Steve Sistare 2022-12-06 1530 pgoff1 = vma->vm_pgoff; f42f5cc4de6087 Steve Sistare 2022-12-06 1531 len1 = vma->vm_end - vma->vm_start; f42f5cc4de6087 Steve Sistare 2022-12-06 1532 flags1 = vma->vm_flags & mask; f42f5cc4de6087 Steve Sistare 2022-12-06 1533 } f42f5cc4de6087 Steve Sistare 2022-12-06 1534 mmap_read_unlock(mm1); f42f5cc4de6087 Steve Sistare 2022-12-06 1535 f42f5cc4de6087 Steve Sistare 2022-12-06 1536 mmap_read_lock(mm2); f42f5cc4de6087 Steve Sistare 2022-12-06 1537 vma = find_vma(mm2, vaddr2); f42f5cc4de6087 Steve Sistare 2022-12-06 1538 if (vma && vma->vm_file) { f42f5cc4de6087 Steve Sistare 2022-12-06 1539 inode2 = vma->vm_file->f_inode; f42f5cc4de6087 Steve Sistare 2022-12-06 1540 pgoff2 = vma->vm_pgoff; f42f5cc4de6087 Steve Sistare 2022-12-06 1541 len2 = vma->vm_end - vma->vm_start; f42f5cc4de6087 Steve Sistare 2022-12-06 1542 flags2 = vma->vm_flags & mask; f42f5cc4de6087 Steve Sistare 2022-12-06 1543 } f42f5cc4de6087 Steve Sistare 2022-12-06 1544 mmap_read_unlock(mm2); f42f5cc4de6087 Steve Sistare 2022-12-06 1545 f42f5cc4de6087 Steve Sistare 2022-12-06 @1546 if (!inode1 || (inode1 != inode2) || (pgoff1 != pgoff2) || Presumably the combination of checking !inode1 and inode1 != inode2 prevents an uninitialized variable use, but it's not clear. f42f5cc4de6087 Steve Sistare 2022-12-06 @1547 (len1 != len2) || (flags1 != flags2)) { f42f5cc4de6087 Steve Sistare 2022-12-06 1548 pr_debug("vfio vma mismatch for old va %lx vs new va %lx\n", f42f5cc4de6087 Steve Sistare 2022-12-06 1549 vaddr1, vaddr2); f42f5cc4de6087 Steve Sistare 2022-12-06 1550 return false; f42f5cc4de6087 Steve Sistare 2022-12-06 1551 } else { f42f5cc4de6087 Steve Sistare 2022-12-06 1552 return true; f42f5cc4de6087 Steve Sistare 2022-12-06 1553 } f42f5cc4de6087 Steve Sistare 2022-12-06 1554 } -- 0-DAY CI Kernel Test Service https://01.org/lkp
