On 12/7/2022 3:29 PM, Jason Gunthorpe wrote:
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
On Wed, Dec 07, 2022 at 01:32:34PM -0800, Brett Creeley wrote:
Please implement the P2P states in your device. After long discussions
we really want to see all VFIO migrations implementations support
this.
It is still not clear what qemu will do when it sees devices that do
not support P2P, but it will not be nice.
Does that mean VFIO_MIGRATION_P2P is going to be required going forward or
do we just need to handle the P2P transitions? Can you point me to where
this is being discussed?
It means the device has to support a state where it is not issuing any
outgoing DMA but continuing to process incoming DMA.
This is mandatory to properly support multiple VFIO devices in the
same VM, which is why we want to see all devices implementing it. If
the devices don't support it we may assume it means the device is
broken and qemu will have to actively block P2P at the IOMMU.
There was lots of long threads in around Dec 2021 if I recall, lore
could probably find them. Somewhere around here based on the search
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fkvm%2F20220215155602.GB1046125%40nvidia.com%2F&data=05%7C01%7Cbrett.creeley%40amd.com%7C5b6b2f8d92d34c0deaed08dad8aae13e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638060525686868907%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Qd0VLPAL5LTYBXi40N3OfWlIecgIhJW70FIAwL9O1lQ%3D&reserved=0
Thanks for the info and link.
Brett
Jason
