On Fri, 02 Dec 2022 09:46:15 -0700 Alex Williamson <alex.williamson@xxxxxxxxxx> wrote: > We always need to call put_device() if device_register() fails. > All vfio drivers calling device_register() include a similar unwind > stack via gotos, therefore split device_unregister() into its > device_del() and put_device() components in the unwind path, and > add a goto target to handle only the put_device() requirement. > > Reported-by: Ruan Jinjie <ruanjinjie@xxxxxxxxxx> > Link: https://lore.kernel.org/all/20221118032827.3725190-1-ruanjinjie@xxxxxxxxxx > Fixes: d61fc96f47fd ("sample: vfio mdev display - host device") > Fixes: 9d1a546c53b4 ("docs: Sample driver to demonstrate how to use Mediated device framework.") > Fixes: a5e6e6505f38 ("sample: vfio bochs vbe display (host device for bochs-drm)") > Fixes: 9e6f07cd1eaa ("vfio/ccw: create a parent struct") > Fixes: 36360658eb5a ("s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem") > Cc: Tony Krowiak <akrowiak@xxxxxxxxxxxxx> > Cc: Halil Pasic <pasic@xxxxxxxxxxxxx> > Cc: Jason Herne <jjherne@xxxxxxxxxxxxx> > Cc: Kirti Wankhede <kwankhede@xxxxxxxxxx> > Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx> > Reviewed-by: Eric Farman <farman@xxxxxxxxxxxxx> > Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx> Reviewed-by: Halil Pasic <pasic@xxxxxxxxxxxxx>