Quoting Thomas Huth (2022-12-02 10:09:03) > On 02/12/2022 10.03, Janosch Frank wrote: > > On 12/1/22 09:46, Nico Boehr wrote: > >> Upcoming changes will add a test which is very similar to the existing > >> skey migration test. To reduce code duplication, move the common > >> functions to a library which can be re-used by both tests. > >> > > > > NACK > > > > We're not putting test specific code into the library. > > Do we need a new file (in the third patch) for the new test at all, or could > the new test simply be added to s390x/migration-skey.c instead? Mh, not quite. One test wants to change storage keys *before* migrating, the other *while* migrating. Since we can only migrate once, it is not obvious to me how we could do that in one run. Speaking of one run, what we could do is add a command line argument which decides which test to run and then call the same test with different arguments in unittests.cfg. Other options I can think of (I don't like any of them): - copy the code (probably the worst solution) - header file in s390x which is included by both tests (better, but still bad, means double compilation of the test functions)
