On 2022/12/2 13:44, Tian, Kevin wrote:
From: Liu, Yi L <yi.l.liu@xxxxxxxxx>
Sent: Thursday, December 1, 2022 10:56 PM
subject: 'helpfers' -> 'helpers'
This makes vfio_device_open/close() to be the top level helpers for device
open and close. It handles the open_count, and vfio_device_first_open()
vfio_device_last_close() do the container/iommufd use/unuse and the
device
open.
Current vfio_device_open() handles the device open and the device file
open which is group specific. After this change, the group specific code
is in the vfio_device_open_file() which would be moved to separate group
source code in future.
It's clearer as below:
--
vfio: Make vfio_device_open() truly device specific
Then move group related logic into vfio_device_open_file(). Accordingly
introduce a vfio_device_close() to pair up.
--
With above:
Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
thanks, I'll update your comments into the github branch.
--
Regards,
Yi Liu