On Thu, Dec 01, 2022 at 04:59:08PM -0700, Alex Williamson wrote: > On Thu, 01 Dec 2022 12:34:33 +0100 > Cornelia Huck <cohuck@xxxxxxxxxx> wrote: > > > On Tue, Nov 29 2022, Jason Gunthorpe <jgg@xxxxxxxxxx> wrote: > > > > > The vfio_spapr_pci_eeh_open/release() functions are one line wrappers > > > around an arch function. Just call them directly and move them into > > > vfio_pci_priv.h. This eliminates some weird exported symbols that don't > > > > Hm, that doesn't seem to match the current patch -- the only change to > > vfio_pci_priv.h is removing an empty line :) > > s/ and move them into vfio_pci_priv.h//? Yes, and drop this: > > > drivers/vfio/pci/vfio_pci_priv.h | 1 - It is a rebase error, I didn't notice it. I made the two notes from Cornelia in my branch, I can send a v5 tomorrow. Thanks, Jason