On Sun, Nov 20, 2022 at 5:42 PM wangyanan (Y) <wangyanan55@xxxxxxxxxx> wrote: > > On 2022/11/19 9:25, David Matlack wrote: > > On Fri, Nov 18, 2022 at 8:58 AM David Matlack <dmatlack@xxxxxxxxxx> wrote: > >> On Fri, Nov 18, 2022 at 12:28 AM wangyanan (Y) <wangyanan55@xxxxxxxxxx> wrote: > >>> Hi David, > >>> > >>> On 2022/11/17 8:16, David Matlack wrote: > >>>> Obey kvm.halt_poll_ns in VMs not using KVM_CAP_HALT_POLL on every halt, > >>>> rather than just sampling the module parameter when the VM is first > >>> s/first/firstly > >>>> created. This restore the original behavior of kvm.halt_poll_ns for VMs > >>> s/restore/restores > >>>> that have not opted into KVM_CAP_HALT_POLL. > >>>> > >>>> Notably, this change restores the ability for admins to disable or > >>>> change the maximum halt-polling time system wide for VMs not using > >>>> KVM_CAP_HALT_POLL. > >>> Should we add more detailed comments about relationship > >>> between KVM_CAP_HALT_POLL and kvm.halt_poll_ns in > >>> Documentation/virt/kvm/api.rst? Something like: > >>> "once KVM_CAP_HALT_POLL is used for a target VM, it will > >>> completely ignores any future changes to kvm.halt_poll_ns..." > >> Yes we should. > >> > >> I will do some testing on this series today and then resend the series > >> as a non-RFC with the Documentation changes. > >> > >> Thanks for the reviews. > > Initial testing looks good but I did not have time to finish due to a > > bug in how our VMM is currently using KVM_CAP_HALT_POLL. I will be out > > all next week so I'll pick this up the week after. > OK, thanks. I see that Linus already merged these patches into 6.1-rc7, so I've sent the Documentation changes as a separate series. https://lore.kernel.org/kvm/20221201195249.3369720-1-dmatlack@xxxxxxxxxx/
