Use the new macros in the existing code. No functional changes intended.
Signed-off-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx>
Reviewed-by: Janis Schoetterl-Glausch <scgl@xxxxxxxxxxxxx>
---
s390x/adtl-status.c | 24 ++++----------------
s390x/firq.c | 5 +----
s390x/migration.c | 6 +----
s390x/skrf.c | 7 +-----
s390x/smp.c | 53 ++++++++++-----------------------------------
s390x/uv-host.c | 5 +----
6 files changed, 19 insertions(+), 81 deletions(-)
diff --git a/s390x/adtl-status.c b/s390x/adtl-status.c
index 9fb76319..2db650a1 100644
--- a/s390x/adtl-status.c
+++ b/s390x/adtl-status.c
@@ -205,16 +205,11 @@ static void restart_write_vector(void)
static void cpu_write_magic_to_vector_regs(uint16_t cpu_idx)
{
- struct psw new_psw;
-
smp_cpu_stop(cpu_idx);
- new_psw.mask = extract_psw_mask();
- new_psw.addr = (unsigned long)restart_write_vector;
-
set_flag(0);
- smp_cpu_start(cpu_idx, new_psw);
+ smp_cpu_start(cpu_idx, PSW_WITH_CUR_MASK(restart_write_vector));
wait_for_flag();
}
@@ -241,7 +236,6 @@ static int adtl_status_check_unmodified_fields_for_lc(unsigned long lc)
static void __store_adtl_status_vector_lc(unsigned long lc)
{
uint32_t status = -1;
- struct psw psw;
int cc;
report_prefix_pushf("LC %lu", lc);
@@ -274,9 +268,7 @@ static void __store_adtl_status_vector_lc(unsigned long lc)
* Destroy and re-initalize the CPU to fix that.
*/
smp_cpu_destroy(1);
- psw.mask = extract_psw_mask();
- psw.addr = (unsigned long)test_func;
- smp_cpu_setup(1, psw);
+ smp_cpu_setup(1, PSW_WITH_CUR_MASK(test_func));
out:
report_prefix_pop();
@@ -325,16 +317,11 @@ static void restart_write_gs_regs(void)
static void cpu_write_to_gs_regs(uint16_t cpu_idx)
{
- struct psw new_psw;
-
smp_cpu_stop(cpu_idx);
- new_psw.mask = extract_psw_mask();
- new_psw.addr = (unsigned long)restart_write_gs_regs;
-
set_flag(0);
- smp_cpu_start(cpu_idx, new_psw);
+ smp_cpu_start(cpu_idx, PSW_WITH_CUR_MASK(restart_write_gs_regs));
wait_for_flag();
}
@@ -382,7 +369,6 @@ out:
int main(void)
{
- struct psw psw;
report_prefix_push("adtl_status");
if (smp_query_num_cpus() == 1) {
@@ -391,9 +377,7 @@ int main(void)
}
/* Setting up the cpu to give it a stack and lowcore */
- psw.mask = extract_psw_mask();
- psw.addr = (unsigned long)test_func;
- smp_cpu_setup(1, psw);
+ smp_cpu_setup(1, PSW_WITH_CUR_MASK(test_func));
smp_cpu_stop(1);
test_store_adtl_status_unavail();
diff --git a/s390x/firq.c b/s390x/firq.c
index b4b3542e..0d65d87f 100644
--- a/s390x/firq.c
+++ b/s390x/firq.c
@@ -33,7 +33,6 @@ static void wait_for_sclp_int(void)
*/
static void test_wait_state_delivery(void)
{
- struct psw psw;
SCCBHeader *h;
int ret;
@@ -55,9 +54,7 @@ static void test_wait_state_delivery(void)
sclp_mark_busy();
/* Start CPU #1 and let it wait for the interrupt. */
- psw.mask = extract_psw_mask();
- psw.addr = (unsigned long)wait_for_sclp_int;
- ret = smp_cpu_setup(1, psw);
+ ret = smp_cpu_setup(1, PSW_WITH_CUR_MASK(wait_for_sclp_int));
/* This must not fail because we have at least 3 CPUs */
assert(!ret);
diff --git a/s390x/migration.c b/s390x/migration.c
index a4529637..a4aa22e7 100644
--- a/s390x/migration.c
+++ b/s390x/migration.c
@@ -158,8 +158,6 @@ static void test_func(void)
int main(void)
{
- struct psw psw;
-
/* don't say migrate here otherwise we will migrate right away */
report_prefix_push("migration");
@@ -169,9 +167,7 @@ int main(void)
}
/* Second CPU does the actual tests */
- psw.mask = extract_psw_mask();
- psw.addr = (unsigned long)test_func;
- smp_cpu_setup(1, psw);
+ smp_cpu_setup(1, PSW_WITH_CUR_MASK(test_func));
/* wait for thread setup */
while(!flag_thread_complete)
diff --git a/s390x/skrf.c b/s390x/skrf.c
index 4cb563c3..e72a2b19 100644
--- a/s390x/skrf.c
+++ b/s390x/skrf.c
@@ -151,11 +151,6 @@ static void ecall_setup(void)
static void test_exception_ext_new(void)
{
- struct psw psw = {
- .mask = extract_psw_mask(),
- .addr = (unsigned long)ecall_setup
- };
-
report_prefix_push("exception external new");
if (smp_query_num_cpus() < 2) {
report_skip("Need second cpu for exception external new test.");
@@ -163,7 +158,7 @@ static void test_exception_ext_new(void)
return;
}
- smp_cpu_setup(1, psw);
+ smp_cpu_setup(1, PSW_WITH_CUR_MASK(ecall_setup));
wait_for_flag();
set_flag(0);
diff --git a/s390x/smp.c b/s390x/smp.c
index 91f3e3bc..2b03bf0c 100644
--- a/s390x/smp.c
+++ b/s390x/smp.c
@@ -101,12 +101,8 @@ static void test_func(void)
static void test_start(void)
{
- struct psw psw;
- psw.mask = extract_psw_mask();
- psw.addr = (unsigned long)test_func;
-
set_flag(0);
- smp_cpu_start(1, psw);
+ smp_cpu_start(1, PSW_WITH_CUR_MASK(test_func));
wait_for_flag();
report_pass("start");
}
@@ -120,8 +116,7 @@ static void test_restart(void)
report_prefix_push("restart");
report_prefix_push("stopped");
- lc->restart_new_psw.mask = extract_psw_mask();
- lc->restart_new_psw.addr = (unsigned long)test_func;
+ lc->restart_new_psw = PSW_WITH_CUR_MASK(test_func);
/* Make sure cpu is stopped */
smp_cpu_stop(1);
@@ -256,7 +251,6 @@ static void test_set_prefix(void)
struct lowcore *new_lc = alloc_pages_flags(1, AREA_DMA31);
struct cpu *cpu1 = smp_cpu_from_idx(1);
uint32_t status = 0;
- struct psw new_psw;
int cc;
report_prefix_push("set prefix");
@@ -268,9 +262,7 @@ static void test_set_prefix(void)
report_prefix_push("running");
set_flag(0);
- new_psw.addr = (unsigned long)stpx_and_set_flag;
- new_psw.mask = extract_psw_mask();
- smp_cpu_start(1, new_psw);
+ smp_cpu_start(1, PSW_WITH_CUR_MASK(stpx_and_set_flag));
wait_for_flag();
cpu1_prefix = 0xFFFFFFFF;
@@ -326,7 +318,6 @@ static void call_received(void)
static void test_calls(void)
{
int i;
- struct psw psw;
for (i = 0; i < ARRAY_SIZE(cases_sigp_call); i++) {
current_sigp_call_case = &cases_sigp_call[i];
@@ -339,9 +330,7 @@ static void test_calls(void)
}
set_flag(0);
- psw.mask = extract_psw_mask();
- psw.addr = (unsigned long)call_received;
- smp_cpu_start(1, psw);
+ smp_cpu_start(1, PSW_WITH_CUR_MASK(call_received));
/* Wait until the receiver has finished setup */
wait_for_flag();
@@ -389,7 +378,6 @@ static void call_in_wait_cleanup(void)
static void test_calls_in_wait(void)
{
int i;
- struct psw psw;
report_prefix_push("psw wait");
for (i = 0; i < ARRAY_SIZE(cases_sigp_call); i++) {
@@ -404,9 +392,7 @@ static void test_calls_in_wait(void)
/* Let the secondary CPU setup the external mask and the external interrupt cleanup function */
set_flag(0);
- psw.mask = extract_psw_mask();
- psw.addr = (unsigned long)call_in_wait_setup;
- smp_cpu_start(1, psw);
+ smp_cpu_start(1, PSW_WITH_CUR_MASK(call_in_wait_setup));
/* Wait until the receiver has finished setup */
wait_for_flag();
@@ -422,9 +408,7 @@ static void test_calls_in_wait(void)
* wait until the CPU becomes operating (done by smp_cpu_start).
*/
smp_cpu_stop(1);
- psw.mask = extract_psw_mask() | PSW_MASK_EXT | PSW_MASK_WAIT;
- psw.addr = (unsigned long)call_in_wait_received;
- smp_cpu_start(1, psw);
+ smp_cpu_start(1, PSW(extract_psw_mask() | PSW_MASK_EXT | PSW_MASK_WAIT, call_in_wait_received));
smp_sigp(1, current_sigp_call_case->call, 0, NULL);
@@ -439,9 +423,7 @@ static void test_calls_in_wait(void)
* to catch an interrupt that is presented twice since we would
* disable the external call on the first interrupt.
*/
- psw.mask = extract_psw_mask();
- psw.addr = (unsigned long)call_in_wait_cleanup;
- smp_cpu_start(1, psw);
+ smp_cpu_start(1, PSW_WITH_CUR_MASK(call_in_wait_cleanup));
/* Wait until the cleanup has been completed */
wait_for_flag();
@@ -478,15 +460,11 @@ static void test_func_initial(void)
static void test_reset_initial(void)
{
struct cpu_status *status = alloc_pages_flags(0, AREA_DMA31);
- struct psw psw;
int i;
- psw.mask = extract_psw_mask();
- psw.addr = (unsigned long)test_func_initial;
-
report_prefix_push("reset initial");
set_flag(0);
- smp_cpu_start(1, psw);
+ smp_cpu_start(1, PSW_WITH_CUR_MASK(test_func_initial));
wait_for_flag();
smp_sigp(1, SIGP_INITIAL_CPU_RESET, 0, NULL);
@@ -525,22 +503,16 @@ static void test_local_ints(void)
static void test_reset(void)
{
- struct psw psw;
-
- psw.mask = extract_psw_mask();
- psw.addr = (unsigned long)test_func;
-
report_prefix_push("cpu reset");
smp_sigp(1, SIGP_EMERGENCY_SIGNAL, 0, NULL);
smp_sigp(1, SIGP_EXTERNAL_CALL, 0, NULL);
- smp_cpu_start(1, psw);
+ smp_cpu_start(1, PSW_WITH_CUR_MASK(test_func));
smp_sigp(1, SIGP_CPU_RESET, 0, NULL);
report(smp_cpu_stopped(1), "cpu stopped");
set_flag(0);
- psw.addr = (unsigned long)test_local_ints;
- smp_cpu_start(1, psw);
+ smp_cpu_start(1, PSW_WITH_CUR_MASK(test_local_ints));
wait_for_flag();
report_pass("local interrupts cleared");
report_prefix_pop();
@@ -548,7 +520,6 @@ static void test_reset(void)
int main(void)
{
- struct psw psw;
report_prefix_push("smp");
if (smp_query_num_cpus() == 1) {
@@ -557,9 +528,7 @@ int main(void)
}
/* Setting up the cpu to give it a stack and lowcore */
- psw.mask = extract_psw_mask();
- psw.addr = (unsigned long)test_func;
- smp_cpu_setup(1, psw);
+ smp_cpu_setup(1, PSW_WITH_CUR_MASK(test_func));
smp_cpu_stop(1);
test_start();
diff --git a/s390x/uv-host.c b/s390x/uv-host.c
index 9f09f80e..33e6eec6 100644
--- a/s390x/uv-host.c
+++ b/s390x/uv-host.c
@@ -501,7 +501,6 @@ static void test_init(void)
{
int rc;
uint64_t mem;
- struct psw psw;
/* Donated storage needs to be over 2GB */
mem = (uint64_t)memalign_pages_flags(SZ_1M, uvcb_qui.uv_base_stor_len, AREA_NORMAL);
@@ -547,9 +546,7 @@ static void test_init(void)
"storage below 2GB");
uvcb_init.stor_origin = mem;
- psw.mask = extract_psw_mask();
- psw.addr = (unsigned long)cpu_loop;
- smp_cpu_setup(1, psw);
+ smp_cpu_setup(1, PSW_WITH_CUR_MASK(cpu_loop));
rc = uv_call(0, (uint64_t)&uvcb_init);
report(rc == 1 && uvcb_init.header.rc == 0x102,
"too many running cpus");
--
2.38.1
