Re: [kvm-unit-tests PATCH v2 1/2] s390x: add a library for CMM-related functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Thomas Huth (2022-11-25 14:45:53)
> On 24/11/2022 14.44, Nico Boehr wrote:
[...]
> > diff --git a/lib/s390x/cmm.c b/lib/s390x/cmm.c
> > new file mode 100644
> > index 000000000000..5da02fe628f9
[...]
> > +/*
> > + * Maps ESSA actions to states the page is allowed to be in after the
> > + * respective action was executed.
> > + */
> > +const int allowed_essa_state_masks[4] = {
> 
> Could be declared as "static const int ...", I guess?

Yes, done.

> Apart from that nit:
> Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>

Thanks.




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux