On Wed, Nov 23, 2022, Peter Zijlstra wrote: > On Tue, Nov 22, 2022 at 08:52:35PM +0000, Sean Christopherson wrote: > > > Another wart that needs to be addressed is trace_kvm_exit(). IIRC, tracepoints > > must be outside of noinstr, though maybe I'm misremembering that. > > You are not, that is correct. Another point to be careful with is usage > of jump_label and static_call, both can be used in noinstr *provided* > they don't actually ever change -- so boot time setup only. > > If either of them were to change, text_poke_bp() has a clue in the name. I think we're mostly ok on that front. kvm_wait_lapic_expire() consumes multiple static keys that can change at will, but that can be kept outside of the noinstr section. Thanks!
