On 11/21/22 1:37 AM, Huang, Kai wrote: >> Also why is this global variable? At least in this patch, there seems to >> be no use case. > Platform_tdx_enabled() uses tdx_keyid_num to determine whether TDX is enabled by > BIOS. > > Also, in the changlog I can add "both initializing the TDX module and creating > TDX guest will need to use TDX private KeyID". > > But I also have a comment saying something similar around ... > I am asking about the tdx_keyid_start. It mainly used in detect_tdx(). Maybe you declared it as global as a preparation for next patches. But it is not explained in change log. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer
