On 11/20/22 18:52, Sathyanarayanan Kuppuswamy wrote: > On 11/20/22 4:26 PM, Kai Huang wrote: >> +/* >> + * TDX supported page sizes (4K/2M/1G). >> + * >> + * Those values are part of the TDX module ABI. Do not change them. > It would be better if you include specification version and section > title. I actually think TDX code, in general, spends way too much time quoting and referring to the spec. Also, why quote the version? Do we quote the SDM version when we add new SDM-defined architecture? It's just busywork that bloats the kernel and adds noise. Please focus on adding value to the comments that came from your brain and not just pasting boilerplate gunk over and over.