On Wed, Nov 16, 2022 at 09:42:34AM +0000, "Huang, Kai" <kai.huang@xxxxxxxxx> wrote: > On Sat, 2022-10-29 at 23:22 -0700, isaku.yamahata@xxxxxxxxx wrote: > > From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx> > > > > Factor out non-leaf SPTE population logic from kvm_tdp_mmu_map(). MapGPA > > hypercall needs to populate non-leaf SPTE to record which GPA, private or > > shared, is allowed in the leaf EPT entry. > > Is this patch still valid/needed since you have changed to use XArray to store > whether GFN is private or shared? Because tdp_mmu_populate_nonleaf() won't be touched any more, this patch doesn't have any benefit. Will drop it. -- Isaku Yamahata <isaku.yamahata@xxxxxxxxx>