On 11/15/22 18:31, Sean Christopherson wrote:
On Tue, Nov 15, 2022, guo.ziliang@xxxxxxxxxx wrote:
From: guo ziliang <guo.ziliang@xxxxxxxxxx>
Fix the following coccicheck warning:
/virt/kvm/kvm_main.c: 3849: 0-23: WARNING: vcpu_get_pid_fops
should be defined with DEFINE_DEBUGFS_ATTRIBUTE
Signed-off-by: guo ziliang <guo.ziliang@xxxxxxxxxx>
---
virt/kvm/kvm_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 2719e10..6e58aec 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -3846,7 +3846,7 @@ static int vcpu_get_pid(void *data, u64 *val)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(vcpu_get_pid_fops, vcpu_get_pid, NULL, "%llu\n");
++DEFINE_DEBUGFS_ATTRIBUTE(vcpu_get_pid_fops, vcpu_get_pid, NULL, "%llu\n");
NAK, third time is not a charm.
https://lore.kernel.org/all/20221101072506.7307-1-liubo03@xxxxxxxxxx
https://lore.kernel.org/all/20220815031228.64126-1-ye.xingchen@xxxxxxxxxx
Screw it, I'm going to send a pull request just to delete that file.
Paolo
