On Tue, 15 Nov 2022 11:15:33 +0000
Fuad Tabba <tabba@xxxxxxxxxx> wrote:
Hi,
> If none of the bank types match, the function would return an
> uninitialized value.
>
> Signed-off-by: Fuad Tabba <tabba@xxxxxxxxxx>
Indeed the comment promises to return 0 if there is no error.
Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>
Cheers,
Andre
> ---
> kvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kvm.c b/kvm.c
> index 42b8812..78bc0d8 100644
> --- a/kvm.c
> +++ b/kvm.c
> @@ -387,7 +387,7 @@ int kvm__for_each_mem_bank(struct kvm *kvm, enum kvm_mem_type type,
> int (*fun)(struct kvm *kvm, struct kvm_mem_bank *bank, void *data),
> void *data)
> {
> - int ret;
> + int ret = 0;
> struct kvm_mem_bank *bank;
>
> list_for_each_entry(bank, &kvm->mem_banks, list) {
