On Fri, Nov 11, 2022 at 02:07:05PM -0800, H. Peter Anvin wrote: > On November 10, 2022 11:55:22 AM PST, "Li, Xin3" <xin3.li@xxxxxxxxx> wrote: > >> > Signed-off-by: H. Peter Anvin (Intel) <hpa@xxxxxxxxx> > >> > Signed-off-by: Xin Li <xin3.li@xxxxxxxxx> > >> > >> This is not a valid SOB, it would suggest hpa is the author, but he's not in in > >> From. > > > >HPA wrote the initial dispatch code for FRED, and I worked with him to > >refactor it for KVM/VMX NMI/IRQ dispatch. So use SOB from both. No? > > > >> > diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index > >> > 178015a820f0..95dd917ef9ad 100644 > >> > --- a/arch/x86/kernel/traps.c > >> > +++ b/arch/x86/kernel/traps.c > >> > @@ -1444,6 +1444,61 @@ DEFINE_IDTENTRY_SW(iret_error) } #endif > >> > > >> > +#define SYSV(x,y) [(x) - FIRST_SYSTEM_VECTOR] = > >> > +(system_interrupt_handler)y > >> > + > >> > +#pragma GCC diagnostic push > >> > +#pragma GCC diagnostic ignored "-Wcast-function-type" > >> > >> How does this not break CFI ? > > > >I wasn't aware of it, will check. > > > > It doesn't break CFI because the arguments passed is always a strict > superset of the ones expected and they are free enough that they are > always passed in registers. It does break CFI because the signature hash doesn't match and you'll trigger an explicit UD2.
