On Fri, Nov 11, 2022 at 05:07:35PM +0000, Sean Christopherson wrote: > On Fri, Nov 11, 2022, Yan Zhao wrote: > > KVMGT only cares about when a slot is indeed removed. > > So switch to use track_remove_slot which is called when a slot is removed. > > This should capture the original motivation, i.e. that the existing > ->track_flush_slot() hook is theoretically flawed. I think it also makes sense > to call out that KVMGT undoubtedly does the wrong thing if a memslot is moved, > but that (a) KVMGT has never supported moving memslots and (b) there's no sane > use case for moving memslots that might be used by the guest for the GTT. > > Bonus points if you can figure out a way to capture the restriction in the docs, > e.g. somewhere in gpu/i915.rst? > > Lastly, provide a link to the original discussion which provides even more context. > > Link: https://lore.kernel.org/all/20221108084416.11447-1-yan.y.zhao@xxxxxxxxx > Got it. I'll do it next time! Thanks Yan > > Cc: Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx> > > Suggested-by: Sean Christopherson <seanjc@xxxxxxxxxx> > > Signed-off-by: Yan Zhao <yan.y.zhao@xxxxxxxxx> > > ---
