Re: [PATCH 1/2] vfio-ccw: sort out physical vs virtual pointers usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Eric Farman (2022-11-10 15:28:51)
[...]
> > So the hardware actually doesn't care what kind of address this is.
> > Rather, the
> > CIO driver expects the intparam to be a physical address - probably
> > so it fits
> > 32 bits -, see do_cio_interrupt.
> 
> Right, it doesn't even need to be an address; we could write 0xdeadbeef
> if we wanted, so long as that could be decoded by the driver on the
> interrupt side. I really just wanted to point out that it was sent to
> the channel, not that the channel (or anything else on the hardware
> side) used it. What about this?
> 
>    The ORB's interrupt parameter field is stored unmodified into the
>    interruption code when an I/O interrupt occurs. As this reflects
>    a real device, let's store the physical address of the subchannel
>    struct so it can be used when processing an interrupt.

Sounds good to me.

With this fixed:
Reviewed-by: Nico Boehr <nrb@xxxxxxxxxxxxx>




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux