> -----Original Message----- > From: ruanjinjie > Sent: 09 November 2022 09:37 > To: jgg@xxxxxxxx; yishaih@xxxxxxxxxx; Shameerali Kolothum Thodi > <shameerali.kolothum.thodi@xxxxxxxxxx>; kevin.tian@xxxxxxxxx; > alex.williamson@xxxxxxxxxx; cohuck@xxxxxxxxxx; kvm@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx > Cc: ruanjinjie <ruanjinjie@xxxxxxxxxx> > Subject: [PATCH -next] vfio/mlx5: use module_pci_driver > > mlx5vf_pci_init and mlx5vf_pci_cleanup with module_init and module_exit > calls can be replaced with the module_pci_driver call, as they are similar > to what module_pci_driver does There is already a patch out there, https://lore.kernel.org/kvm/20220922123507.11222-1-shangxiaojing@xxxxxxxxxx/ Thanks, Shameer > Signed-off-by: ruanjinjie <ruanjinjie@xxxxxxxxxx> > --- > drivers/vfio/pci/mlx5/main.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/vfio/pci/mlx5/main.c b/drivers/vfio/pci/mlx5/main.c > index fd6ccb8454a2..457138b92f13 100644 > --- a/drivers/vfio/pci/mlx5/main.c > +++ b/drivers/vfio/pci/mlx5/main.c > @@ -676,18 +676,7 @@ static struct pci_driver mlx5vf_pci_driver = { > .driver_managed_dma = true, > }; > > -static void __exit mlx5vf_pci_cleanup(void) > -{ > - pci_unregister_driver(&mlx5vf_pci_driver); > -} > - > -static int __init mlx5vf_pci_init(void) > -{ > - return pci_register_driver(&mlx5vf_pci_driver); > -} > - > -module_init(mlx5vf_pci_init); > -module_exit(mlx5vf_pci_cleanup); > +module_pci_driver(mlx5vf_pci_driver); > > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Max Gurtovoy <mgurtovoy@xxxxxxxxxx>"); > -- > 2.25.1
