Re: [kvm-unit-tests PATCH v4 23/24] x86/pmu: Update testcases to cover AMD PMU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 02, 2022, Sean Christopherson wrote:
> On Mon, Oct 24, 2022, Like Xu wrote:
> >  static inline bool this_cpu_has_pmu(void)
> >  {
> > +	if (!is_intel())
> > +		return true;
> 
> I think it makes sense to kill off this_cpu_has_pmu(), the only usage is after
> an explicit is_intel() check, and practically speaking that will likely hold true
> since differentiating between Intel and AMD PMUs seems inevitable.

Rats, this won't work as vmx_tests.c uses the wrapper.  That's obviously Intel-only
too, but funneling that code through pmu_version() or whatever is rather gross.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux