On Tue, Nov 01, 2022 at 07:38:47AM +0000, Tian, Kevin wrote: > > From: Jason Gunthorpe <jgg@xxxxxxxxxx> > > Sent: Wednesday, October 26, 2022 2:17 AM > > > > +err_container: > > + vfio_device_unassign_container(device); > > err_module_put: > > device->kvm = NULL; > > err_module_put should be moved after nullifying device->kvm. > > otherwise it looks good to me: > > Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx> Done, thanks Jason