On Thu, Oct 27, 2022, Colton Lewis wrote: > diff --git a/tools/testing/selftests/kvm/lib/perf_test_util.c b/tools/testing/selftests/kvm/lib/perf_test_util.c > index 9618b37c66f7..5f0eebb626b5 100644 > --- a/tools/testing/selftests/kvm/lib/perf_test_util.c > +++ b/tools/testing/selftests/kvm/lib/perf_test_util.c > @@ -49,6 +49,7 @@ void perf_test_guest_code(uint32_t vcpu_idx) > uint64_t gva; > uint64_t pages; > int i; > + struct guest_random_state rand_state = new_guest_random_state(pta->random_seed + vcpu_idx); This belong in the first patch that consumes rand_state, which I believe is patch 3. lib/perf_test_util.c: In function ‘perf_test_guest_code’: lib/perf_test_util.c:52:35: error: unused variable ‘rand_state’ [-Werror=unused-variable] 52 | struct guest_random_state rand_state = new_guest_random_state(pta->random_seed + vcpu_idx); |