Re: [PATCH v7 3/3] KVM: selftests: randomize page access order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sean Christopherson <seanjc@xxxxxxxxxx> writes:

On Wed, Oct 19, 2022, Colton Lewis wrote:
@@ -422,11 +426,15 @@ int main(int argc, char *argv[])

  	guest_modes_append_default();

-	while ((opt = getopt(argc, argv, "eghi:p:m:nb:v:or:s:x:w:")) != -1) {
+	while ((opt = getopt(argc, argv, "aeghi:p:m:nb:v:or:s:x:w:")) != -1) {
  		switch (opt) {
+		case 'a':
+			p.random_access = true;
+			break;
  		case 'e':
  			/* 'e' is for evil. */
  			run_vcpus_while_disabling_dirty_logging = true;
+			break;

Heh, I appreciate the fix for my bug, but this belongs in a separate patch. Isolating bug fixes isn't exactly critical for selftests, but it does matter. E.g. Vipin also has an in-flight patch to fix this, and isolating the fix makes
it easier on maintainers to resolve the conflicts between the two series.

[*] https://lore.kernel.org/all/20221021211816.1525201-2-vipinsh@xxxxxxxxxx

Unintentional, I had a conflict there and assumed there was a break
there.

Will take it out.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux