On Thu, Oct 27, 2022 at 8:44 AM Sean Christopherson <seanjc@xxxxxxxxxx> wrote: > > On Thu, Oct 27, 2022, Wang, Wei W wrote: > > On Thursday, October 27, 2022 5:23 AM, David Matlack: > > > I haven't dug too much into the actual code yet, but I have some high level > > > feedback based on a quick look through the series: > > > > > > - Use the format "KVM: selftests: <Decsription>" for the shortlog. > > > > I know it's not common to see so far, but curious is this the required format? > > It's definitely the preferred format. > > > I didn't find where it's documented. > > Heh, for all shortlog scopes, the "documentation" is `git log --pretty=oneline` :-) > > > If it's indeed a requirement, probably we also need to enhance checkpatch.pl > > to detect this. > > I like the idea in theory, but that'd be a daunting task to set up, and quite the > maintenance nightmare. There are probably thousands of file => scope mappings > throughout the kernel, with any number of exceptions and arbitrary rules. I was thinking about proposing this in checkpatch.pl, or in some KVM-specific check script. It seems like the following rule: If a commit only modifies files in tools/testing/selftests/kvm/*, then requires the shortlog match the regex "KVM: selftests: .*". That would handle the vast majority of cases without affecting other subsystems. Sean are you more concerned that if we start validating shortlogs in checkpatch.pl then eventually it will get too out of hand? (i.e. not so concerned with this specific case, but the general problem?) Either way, we should at least document the preferred KVM shortlog styles in Documentation/virtual/kvm/.
