Quoting Christian Borntraeger (2022-10-25 08:37:21) [...] > > diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c > > index 94138f8f0c1c..c6a10ff46d58 100644 [...] > > @@ -869,7 +869,7 @@ static int pin_scb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page, > > WARN_ON_ONCE(rc); > > return 1; > > } > > - vsie_page->scb_o = (struct kvm_s390_sie_block *) hpa; > > + vsie_page->scb_o = (struct kvm_s390_sie_block *)phys_to_virt(hpa); > > Do we still need the cast here? phys_to_virt should return a void * and the assignment should succeed. Yes, right. Fixed in v2.