Remove the unnecessary vcpu_thread definition and remove it from the related funtions' input as it can be referenced from the kvm_vcpu struct. Also use the helper functinos to create and join the vcpu thread. Signed-off-by: Wei Wang <wei.w.wang@xxxxxxxxx> --- .../selftests/kvm/set_memory_region_test.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/tools/testing/selftests/kvm/set_memory_region_test.c b/tools/testing/selftests/kvm/set_memory_region_test.c index 0d55f508d595..d233668957da 100644 --- a/tools/testing/selftests/kvm/set_memory_region_test.c +++ b/tools/testing/selftests/kvm/set_memory_region_test.c @@ -1,7 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 #define _GNU_SOURCE /* for program_invocation_short_name */ #include <fcntl.h> -#include <pthread.h> #include <sched.h> #include <semaphore.h> #include <signal.h> @@ -108,8 +107,7 @@ static void wait_for_vcpu(void) usleep(100000); } -static struct kvm_vm *spawn_vm(struct kvm_vcpu **vcpu, pthread_t *vcpu_thread, - void *guest_code) +static struct kvm_vm *spawn_vm(struct kvm_vcpu **vcpu, void *guest_code) { struct kvm_vm *vm; uint64_t *hva; @@ -134,7 +132,7 @@ static struct kvm_vm *spawn_vm(struct kvm_vcpu **vcpu, pthread_t *vcpu_thread, hva = addr_gpa2hva(vm, MEM_REGION_GPA); memset(hva, 0, 2 * 4096); - pthread_create(vcpu_thread, NULL, vcpu_worker, *vcpu); + vm_vcpu_threads_create(vm, vcpu_worker, 0); /* Ensure the guest thread is spun up. */ wait_for_vcpu(); @@ -175,12 +173,11 @@ static void guest_code_move_memory_region(void) static void test_move_memory_region(void) { - pthread_t vcpu_thread; struct kvm_vcpu *vcpu; struct kvm_vm *vm; uint64_t *hva; - vm = spawn_vm(&vcpu, &vcpu_thread, guest_code_move_memory_region); + vm = spawn_vm(&vcpu, guest_code_move_memory_region); hva = addr_gpa2hva(vm, MEM_REGION_GPA); @@ -211,7 +208,7 @@ static void test_move_memory_region(void) /* Defered sync from when the memslot was misaligned (above). */ wait_for_vcpu(); - pthread_join(vcpu_thread, NULL); + vm_vcpu_threads_join(vm); kvm_vm_free(vm); } @@ -254,13 +251,12 @@ static void guest_code_delete_memory_region(void) static void test_delete_memory_region(void) { - pthread_t vcpu_thread; struct kvm_vcpu *vcpu; struct kvm_regs regs; struct kvm_run *run; struct kvm_vm *vm; - vm = spawn_vm(&vcpu, &vcpu_thread, guest_code_delete_memory_region); + vm = spawn_vm(&vcpu, guest_code_delete_memory_region); /* Delete the memory region, the guest should not die. */ vm_mem_region_delete(vm, MEM_REGION_SLOT); @@ -282,7 +278,7 @@ static void test_delete_memory_region(void) */ vm_mem_region_delete(vm, 0); - pthread_join(vcpu_thread, NULL); + vm_vcpu_threads_join(vm); run = vcpu->run; -- 2.27.0