On Mon, Oct 17, 2022 at 11:08:35PM -0700, Christoph Hellwig wrote: > > +#if IS_ENABLED(CONFIG_EEH) && IS_ENABLED(CONFIG_VFIO_IOMMU_SPAPR_TCE) > > #include <asm/eeh.h> > > #endif > > > > @@ -689,7 +689,7 @@ void vfio_pci_core_close_device(struct vfio_device *core_vdev) > > vdev->sriov_pf_core_dev->vf_token->users--; > > mutex_unlock(&vdev->sriov_pf_core_dev->vf_token->lock); > > } > > -#if IS_ENABLED(CONFIG_VFIO_SPAPR_EEH) > > +#if IS_ENABLED(CONFIG_EEH) && IS_ENABLED(CONFIG_VFIO_IOMMU_SPAPR_TCE) > > So while this preserves the existing behavior, I wonder if checking > CONFIG_EEH only would make more sense here. Yes, it does read better, done Thanks, Jason
