On Thu, 20 Oct 2022 13:19:36 +0200 Janosch Frank <frankja@xxxxxxxxxxxxx> wrote: > On 10/20/22 10:57, Claudio Imbrenda wrote: > > On Thu, 20 Oct 2022 09:58:05 +0200 > > Nico Boehr <nrb@xxxxxxxxxxxxx> wrote: > > > >> Quoting Claudio Imbrenda (2022-10-19 11:51:28) > >> [...] > >>> I was thinking that we set pgm_int_expected = false so we would catch a > >>> wild program interrupt there, but in hindsight maybe it's better to set > >>> in_interrupt_handler = true there so we can abort immediately > >> > >> Oh right I missed that. I think how it is right now is nicer because we will get a nice message on the console, right? > > > > which will generate more interrupts > > > > @Janosch do you think it's better with or without setting > > in_interrupt_handler in the pgm interrupt handler? > > > > Any reason why you didn't set it in CALL_INT_HANDLER? because then it will always be set whenever we get a PGM, the if will always be true > > >> > >> In this case: > >> Reviewed-by: Nico Boehr <nrb@xxxxxxxxxxxxx> > >
