Re: [PATCH v2 0/3] KVM: selftests: Rename perf_test_util to memstress

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 12, 2022 at 09:57:26AM -0700, David Matlack wrote:
> This series renames the perf_test_util to memstress. patch 1 renames the files
> perf_test_util.[ch] to memstress.[ch], and patch 2 replaces the perf_test_
> prefix on symbols with memstress_.
> 
> The reason for this rename, as with any rename, is to improve readability.
> perf_test_util is too generic and does not describe at all what the library
> does, other than being used for perf tests.
> 
> I considered a lot of different names (naming is hard) and eventually settled
> on memstress for a few reasons:
> 
>  - "memstress" better describes the functionality proveded by this library,
>    which is to run a VM that reads/writes to memory from all vCPUs in parallel
>    (i.e. stressing VM memory).
> 
>  - "memstress" contains the same number of characters as "perf_test", making
>    it a drop in replacement in symbols wihout changing line lengths.
> 
>  - The lack of underscore between "mem" and "stress" makes it clear "memstress"
>    is a noun, avoiding confusion in function names.
> 
> Looking to the future, I think "memstress" will remain a good name. Specifically
> there are some in-flight improvements that will make this library even more of
> a "memory stress tester":
> 
>  - A proposed series by yours truly [1] extends memstress/perf_test_util to
>    support execute from memory, in addition to reading/writing.
> 
>  - Colton Lewis within Google is looking into adding support for more complex
>    memory access patterns.
> 
> [1] https://lore.kernel.org/kvm/20220401233737.3021889-2-dmatlack@xxxxxxxxxx/
> 
> Cc: Andrew Jones <andrew.jones@xxxxxxxxx>
> Cc: Colton Lewis <coltonlewis@xxxxxxxxxx>
> Cc: Ricardo Koller <ricarkol@xxxxxxxxxx>
> Acked-by: Andrew Jones <andrew.jones@xxxxxxxxx>
> 
> v2:
>  - Add precursor patch to rename pta to args [Sean]
> 
> v1: https://lore.kernel.org/kvm/20220919232300.1562683-1-dmatlack@xxxxxxxxxx/
>  - Rebased on top of kvm/queue
>  - Drop RFC tag.
>  - Add Andrew's Acked-by.
> 
> RFC: https://lore.kernel.org/kvm/20220725163539.3145690-1-dmatlack@xxxxxxxxxx/
>

For the series

Reviewed-by: Andrew Jones <andrew.jones@xxxxxxxxx>



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux