On Mon, Oct 10, 2022 at 12:13:01AM -0700, Christoph Hellwig wrote: > On Mon, Oct 03, 2022 at 12:39:33PM -0300, Jason Gunthorpe wrote: > > This is only 1.8k, putting it in its own module is going to waste more > > space rounding up to a PAGE_SIZE than it is worth. Put it in the main > > vfio.ko module now that kbuild can support multiple .c files. > > Assuming you actually need it (only vfio_platform and vfio_pci actually > need it) and you don't otherwise need EVENTFD support. While I guess > the configfs that do not fit the above aren't the most common they > are real and are a real tradeoff. Well, the config still exists, if someone is building a stripped down kernel they can disable it and save the space. By the time you fully load VFIO this is just noise. I don't have a specific preference here, but I would like to reduce the number of modules just for sanity's sake. Jason
