Re: [kvm-unit-tests PATCH v2 0/2] s390x: Add migration test for guest TOD clock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Am 11.10.22 um 18:10 schrieb Claudio Imbrenda:
On Tue, 11 Oct 2022 17:58:29 +0200
Christian Borntraeger <borntraeger@xxxxxxxxxxxxx> wrote:

Am 11.10.22 um 17:14 schrieb Nico Boehr:
v1->v2:
---
- remove unneeded include
- advance clock by 10 minutes instead of 1 minute (thanks Claudio)
- express get_clock_us() using stck() (thanks Claudio)

The guest TOD clock should be preserved on migration. Add a test to
verify that.

I do not fully agree with this assumption. Its the way it curently is, but we might want to have a configurable or different behaviour in the future.

For example if the difference is smaller than time x it could be allowed to move the time forward to get the guest synced to the new host (never go backward though).

the test is actually testing that the clock does not go backwards,
rather than staying the same

I think this is an must and a perfectly valid test.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux