On Mon, Oct 10, 2022 at 03:32:30PM -0300, Jason Gunthorpe wrote: > On Mon, Oct 10, 2022 at 12:07:15AM -0700, Christoph Hellwig wrote: > > On Mon, Oct 03, 2022 at 12:39:30PM -0300, Jason Gunthorpe wrote: > > > The vfio_spapr_pci_eeh_open/release() functions are one line wrappers > > > around an arch function. Just make them static inline and move them into > > > vfio_pci_priv.h. > > > > Please just kill them entirely - the vfio spapr code depends on EEH > > anyway. In fact I have an old patch to do that floating around > > somewhere, but it's probably less work to just recreate it. > > How do you mean? You want to put the #ifdef in the vfio_pci_core.c at > the only call site? Yes.
