On Mon, Oct 10, 2022, Shivam Kumar wrote: > > > On 07/10/22 11:59 pm, Sean Christopherson wrote: > > On Thu, Sep 15, 2022, Shivam Kumar wrote: > > > + TEST_ASSERT(count <= quota + PML_BUFFER_SIZE, "Invalid number of pages > > > > Clarify _why_ the count is invalid. > In the worst case, the vcpu will be able to dirty 512 more pages than its > dirty quota due to PML. Heh, I know that, I wasn't asking a question. I was saying that the assert should tell the user/developer running the test why the count is "invalid", i.e. why the assert failed. Put yourself in the shoes of a random developer that's new to KVM and knows almost nothing about dirty logging and isn't even aware PML is a thing. Write the assert message for _that_ person.
