Commit c3134ce240eed ("KVM: Replace old tlb flush function with new one
to flush a specified range.") replaces old tlb flush function with
kvm_flush_remote_tlbs_with_address() to do tlb flushing. However, the
gfn range of tlb flushing is wrong in some cases. E.g., when a spte is
dropped, the start gfn of tlb flushing should be the gfn of spte not the
base gfn of SP which contains the spte. Although, as Paolo said, Hyper-V
may treat a 1-page flush the same if the address points to a huge page,
and no fixes are reported so far. So it seems that it works well for
Hyper-V. But it would be better to use the correct size for huge page.
So this patchset would fix them and introduce some helper functions as
David suggested to make the code clear.
Changed from v3:
- Move patch 1 after kvm_flush_remote_tlbs_sptep() is introduced,
Drop kvm_flush_remote_tlbs_direct_sp() helper and use
kvm_flush_remote_tlbs_sptep() instead.
- Wrap changelogs at ~75 chars.
Changed from v2:
- Introduce kvm_flush_remote_tlbs_gfn() in Patch 1 early.
- Move round_gfn_for_level() in tdp_iter.c into mmu_internal.h for
common usage and cleanup the call sites of rounding down the GFN.
- Drop Patch 6.
Changed from v1:
- Align down gfn in kvm_set_pte_rmapp() instead of change iterator->gfn
in rmap_walk_init_level() in Patch 2.
- Introduce some helper functions for common operations as David
suggested.
v3: https://lore.kernel.org/kvm/cover.1663929851.git.houwenlong.hwl@xxxxxxxxxxxx
Hou Wenlong (6):
KVM: x86/mmu: Move round_gfn_for_level() helper into mmu_internal.h
KVM: x86/mmu: Fix wrong gfn range of tlb flushing in
kvm_set_pte_rmapp()
KVM: x86/mmu: Reduce gfn range of tlb flushing in
tdp_mmu_map_handle_target_level()
KVM: x86/mmu: Fix wrong start gfn of tlb flushing with range
KVM: x86/mmu: Fix wrong gfn range of tlb flushing in
validate_direct_spte()
KVM: x86/mmu: Cleanup range-based flushing for given page
arch/x86/kvm/mmu/mmu.c | 36 +++++++++++++++++++++------------
arch/x86/kvm/mmu/mmu_internal.h | 15 ++++++++++++++
arch/x86/kvm/mmu/paging_tmpl.h | 5 ++---
arch/x86/kvm/mmu/tdp_iter.c | 11 +++-------
arch/x86/kvm/mmu/tdp_mmu.c | 6 ++----
5 files changed, 45 insertions(+), 28 deletions(-)
--
2.31.1
