On Wed, Oct 05, 2022, Sean Christopherson wrote: > On Fri, Aug 19, 2022, Like Xu wrote: > > From: Like Xu <likexu@xxxxxxxxxxx> > > > > This unit-test is intended to test the KVM's support for > > the Processor Event Based Sampling (PEBS) which is another > > PMU feature on Intel processors (start from Ice Lake Server). > > > > If a bit in PEBS_ENABLE is set to 1, its corresponding counter will > > write at least one PEBS records (including partial state of the vcpu > > at the time of the current hardware event) to the guest memory on > > counter overflow, and trigger an interrupt at a specific DS state. > > The format of a PEBS record can be configured by another register. > > > > These tests cover most usage scenarios, for example there are some > > specially constructed scenarios (not a typical behaviour of Linux > > PEBS driver). It lowers the threshold for others to understand this > > feature and opens up more exploration of KVM implementation or > > hw feature itself. > > > > Signed-off-by: Like Xu <likexu@xxxxxxxxxxx> > > I responded to the previous version, didn't realize it got merged in with this > series (totally fine, I just missed it). I think all my feedback still applies. > > https://lore.kernel.org/all/Yz3XiP6GBp95YEW9@xxxxxxxxxx Ha, and then I saw the addition of "groups = pmu" in the next patch :-)