Re: [kvm-unit-tests GIT PULL 02/28] s390x: add test for SIGP STORE_ADTL_STATUS order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Thomas Huth (2022-10-05 15:25:03)
> On 05/10/2022 15.18, Nico Boehr wrote:
> > Hi Thomas,
> > 
> > Quoting Thomas Huth (2022-09-20 17:53:28)
> >> On 12/05/2022 11.34, Claudio Imbrenda wrote:
> >> [...]
> >>> diff --git a/s390x/unittests.cfg b/s390x/unittests.cfg
> >>> index 743013b2..256c7169 100644
> >>> --- a/s390x/unittests.cfg
> >>> +++ b/s390x/unittests.cfg
> >>> @@ -146,3 +146,28 @@ extra_params = -device virtio-net-ccw
> >>>    
> >>>    [tprot]
> >>>    file = tprot.elf
> >>> +
> >>> +[adtl-status-kvm]
> >>> +file = adtl-status.elf
> >>> +smp = 2
> >>> +accel = kvm
> >>> +extra_params = -cpu host,gs=on,vx=on
> >>
> >> FWIW, on my z13 LPAR, I now see a warning:
> >>
> >> SKIP adtl-status-kvm (qemu-kvm: can't apply global host-s390x-cpu.gs=on:
> >> Feature 'gs' is not available for CPU model 'z13.2', it was introduced with
> >> later models.)
> >>
> >> Could we silence that somehow?
> > 
> > instead of a SKIP, what would you expect to see in this case? Or do you mean the message inside the parenthesis?
> 
> I meant the message inside the parenthesis ... but thinking about it twice, 
> it's maybe even useful to have it here ... so I'm also fine if we keep it. 
> ... it's just a little bit long ...

We could have

cpu = host

in unittest.cfg for adtl-status-kvm.

But this would mean if the host doesn't support vector or gs, we would just see

PASS adtl-status-kvm

with some skipped tests. So, to me, it feels like the current solution is better even if the error message is ugly and long.




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux