On Tue, Oct 04, 2022 at 12:36:03AM +0200, Philippe Mathieu-Daudé wrote: > Hi Jason, > > Per https://www.qemu.org/docs/master/devel/submitting-a-patch.html#when-resending-patches-add-a-version-tag: > > Send each new revision as a new top-level thread, rather than burying it > in-reply-to an earlier revision, as many reviewers are not looking inside > deep threads for new patches. > > On 3/10/22 12:36, Jason A. Donenfeld wrote: > > As of the kernel commit linked below, Linux ingests an RNG seed > > passed from the hypervisor. So, pass this for the Malta platform, and > > reinitialize it on reboot too, so that it's always fresh. > > > > Cc: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx> > > Cc: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> > > Cc: Aurelien Jarno <aurelien@xxxxxxxxxxx> > > Link: https://git.kernel.org/mips/c/056a68cea01 > > You seem to justify this commit by the kernel commit, which justifies > itself mentioning hypervisor use... So the egg comes first before the > chicken. The kernel justification is that the guest OS needs a good RNG seed. The kernel patch is just saying that the firmware / hypervisor side is where this seed generally expected to come from. This is fine, and not notably different from what Jason's already got wired up for the various other targets in QEMU. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
