[AMD Official Use Only - General] >> We already have sev_issue_cmd_external_user() exported right? >> >> Another option could be to make these wrappers more helpful and less >> silly. >For example. >My point is, whenever something needs to issue a SEV* fw command, something adds a silly wrapper and this will become unwieldy pretty quickly. >If a wrapper is not a dumb one but it actually does preparatory work before issuing the command so that the caller's life is made easy, then yes, by all means. >If it is only plain forwarding a call to sev_do_cmd(), then I question the whole point of the exercise... Well, these all were added as APIs to serve as a abstraction for SEV/SNP guest, and probably it is nice to have an abstracted interface, but I have no issues with replacing these simply with calls to sev_do_cmd(). Thanks, Ashish
